Advertisement:

Author Topic: Experimental Osclass fork  (Read 3622 times)

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 380
  • I am here
Experimental Osclass fork
« on: December 05, 2017, 02:42:56 pm »
Hi Guys,
I have recently created experimental fork of official osclass repo at https://github.com/navjottomer/Osclass
I started with refactoring old code and removing legacy code in Osclass and in future will try to add features, other's can also contribute to this repo by testing alpha release, creating issue or submitting pull request.
I will try to close as many issues I can in my free time, but I greatly need help of other developers who want to contribute in this repo.
Objective of this repo is to test new features and improving code quality in osclass, later we will create pull request to official Osclass repo.
Regards
Navjot tomer

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #1 on: December 05, 2017, 03:32:02 pm »
Just be sure Osclass team AREN'T doing the same thing, in their offices, right now.

I mean don't do work/updating/refactoring that they are already doing (without updating Github).



« Last Edit: December 05, 2017, 03:34:45 pm by Aficionado »

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 380
  • I am here
Re: Experimental Osclass fork
« Reply #2 on: December 05, 2017, 03:48:09 pm »
Which I cannot be sure  ;) without any official notification.
But it would be much better if people create pull request to this repo and after testing via community we create pull request to official one. We can add maintainer to this repo from community, who can decide what should be included and when. It will surely reduce work of official osclass repo maintainers.
We already know that official public repo is not touched in a while, if any core-dev can answer on this thread that how we can contribute more to this project.
I have already made over 65 commits to my repo so I will carry on what I am doing right now.
Regards

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #3 on: December 05, 2017, 03:53:42 pm »
Just to be clear. I'm not saying "don't do it".

Au Contraire.
« Last Edit: December 05, 2017, 06:16:09 pm by Aficionado »

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 380
  • I am here
Re: Experimental Osclass fork
« Reply #4 on: December 05, 2017, 04:47:39 pm »
Ofcourse you didn't said that.

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #5 on: December 06, 2017, 06:27:45 pm »
I'm not a programmer. I checked your github fork, and i was surprised to see the ammount of work you did.

I can't comment on the quality of it (i'm not qualified), but great thanks for your work and your interest in Osclass.

I wish this effort will be in benefit of Osclass and all of us.

 :)

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 380
  • I am here
Re: Experimental Osclass fork
« Reply #6 on: December 06, 2017, 06:41:09 pm »
Thanks!! Really appreciated. But you can always help by testing and reporting issue.
Regards

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #7 on: December 06, 2017, 06:48:40 pm »
Thanks!! Really appreciated. But you can always help by testing and reporting issue.
Regards

And i will do so, if you let us know how ? I mean is it ready for test ? Where and how should we report something ?

Also did anyone from Osclass contacted you ? Anything from them ?

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 380
  • I am here
Re: Experimental Osclass fork
« Reply #8 on: December 06, 2017, 08:17:39 pm »
And i will do so, if you let us know how ? I mean is it ready for test ? Where and how should we report something ?
Also did anyone from Osclass contacted you ? Anything from them ?
You can check this page about how to create new issue https://help.github.com/articles/creating-an-issue/
You can get release from release section of GitHub page and test it in your local environment. Before reporting issue check if it is already fixed in later commit or not.
Keep in mind in starting stage we are more focused on errors not on feature. Because my first goal is to clean osclass code and than update few libraries osclass depends on.
Although I am not saying that you are limited to report errors only, you can create any issue just don't expect that it will be closed before our main goal( It may though).
From osclass team no one has contacted me yet but I have only posted about this yesterday So it is not their fault in anyway.

marius-ciclistu

  • issues
  • Hero Member
  • *
  • Posts: 1684
  • "BE GRATEFUL TO THOSE THAT SUPPORTED YOU"
Re: Experimental Osclass fork
« Reply #9 on: December 08, 2017, 10:31:40 pm »
Hi. Sorry to ask but  recentry I've read about drupal for example, and your description from here is verry similar with drupal's description, in the sense that it doesn't tell you concrete things, only a "nice story".
For example, it would be easier if you gave us some points of interest like: does your version strip the normal osclass of more features that it already doesn't have (excepting the plugins).

Take it as an observation with positive intention:).

Thank you.

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #10 on: December 09, 2017, 10:35:01 am »
Hi. Sorry to ask but  recentry I've read about drupal for example, and your description from here is verry similar with drupal's description, in the sense that it doesn't tell you concrete things, only a "nice story".
For example, it would be easier if you gave us some points of interest like: does your version strip the normal osclass of more features that it already doesn't have (excepting the plugins).


I don't see what "Drupal" has to do with this ReFactroring fork.

I think Navjottomer explained in details what his project is and what not.


marius-ciclistu

  • issues
  • Hero Member
  • *
  • Posts: 1684
  • "BE GRATEFUL TO THOSE THAT SUPPORTED YOU"
Re: Experimental Osclass fork
« Reply #11 on: December 09, 2017, 10:44:04 am »
Only the description style. I for example did not understood what this fork is about by reading the above topic.
If I looked on github at some of the comits, I saw that he cleaned up the code for unnecesary brakets, parantesisis and other lines of code.

Osclass has many bugs that I resolved in my instalation, so if I would to use/test a new 'distribution' of osclass I would like to know the changes in functionality at least.


Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #12 on: December 09, 2017, 10:52:19 am »
Only the description style. I for example did not understood what this fork is about by reading the above topic.
If I looked on github at some of the comits, I saw that he cleaned up the code for unnecesary brakets, parantesisis and other lines of code.

Osclass has many bugs that I resolved in my instalation, so if I would to use/test a new 'distribution' of osclass I would like to know the changes in functionality at least.

I think the following describes 100% the purpose of the fork.

Quote
I started with refactoring old code and removing legacy code in Osclass and in future will try to add features,


marius-ciclistu

  • issues
  • Hero Member
  • *
  • Posts: 1684
  • "BE GRATEFUL TO THOSE THAT SUPPORTED YOU"
Re: Experimental Osclass fork
« Reply #13 on: December 09, 2017, 11:03:19 am »
refactoring old code and removing legacy code

These words made me write an answer :)
Refactoring old code - ok...I could imagine what that is.
Removing legacy code - I have no ideea what that does.

(I'm trying also to learn from this, so don't think my intentions are  negative).

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #14 on: December 09, 2017, 11:07:57 am »
refactoring old code and removing legacy code

These words made me write an answer :)
Refactoring old code - ok...I could imagine what that is.
Removing legacy code - I have no ideea what that does.

(I'm trying also to learn from this, so don't think my intentions are  negative).

I think if you look closely the Github fork you will understand fully what it is for.