Advertisement:

Author Topic: Experimental Osclass fork  (Read 3149 times)

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #15 on: December 09, 2017, 04:54:25 pm »
Removing legacy code means Updating libraries using php4 era syntax. Using modern php5 functions. It is work in progress so I can't comment on what we remove and what we include. I just need help and suggestions right now. It will we morr clear when we achieve our first goal.
Regards
Navjot
« Last Edit: December 09, 2017, 05:00:33 pm by navjottomer »

marius-ciclistu

  • issues
  • Hero Member
  • *
  • Posts: 1619
  • "BE GRATEFUL TO THOSE THAT SUPPORTED YOU"
Re: Experimental Osclass fork
« Reply #16 on: December 09, 2017, 05:42:35 pm »
Thank you. I thought that refactoring old code meant that you update the code acc to newer php versions. Thank you for clarifying.

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #17 on: December 09, 2017, 09:09:31 pm »
I don't see much interest. Anyway.

Just finished backup my online dev installation (home dir AND Database). I will upload the updated files from Github in a while and see how it goes.

I will update here with a summary asap.


Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #18 on: December 09, 2017, 10:29:55 pm »
I don't see option to create an Issue at Github, so ...

After playing a bit with the experiment version and Bender, i only see a lot of this Notice:

[09-Dec-2017 20:30:15 Europe/Madrid] PHP Notice:  Array to string conversion in /home/oc-includes/osclass/helpers/hSanitize.php on line 183

« Last Edit: December 09, 2017, 10:40:38 pm by Aficionado »

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #19 on: December 09, 2017, 10:36:20 pm »
An issue: Switching from bender to OsclassWizards theme, i see this:

[09-Dec-2017 20:36:37 Europe/Madrid] PHP Notice:  Plugin osclasswizards is missing the index.php file /home/oc-content/plugins/osclasswizards/index.php in /home/oc-includes/osclass/classes/Plugins.php on line 124

The Osclasswizards is untouched and i REinstalled it from Market. And Index.php is not missing, it is there.


navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #20 on: December 09, 2017, 11:41:44 pm »
Thanks I will work it. What version of php you are using?
« Last Edit: December 09, 2017, 11:43:29 pm by navjottomer »

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #21 on: December 10, 2017, 01:12:21 am »
Thanks I will work it. What version of php you are using?

I'm using PHP 7.0.26

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #22 on: December 10, 2017, 07:07:29 am »
Thanks I will work it. What version of php you are using?

Also allow Issues to github if you want reports in there.

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #23 on: December 10, 2017, 07:59:11 am »
Thanks I will work it. What version of php you are using?

Also allow Issues to github if you want reports in there.
Oops I forget that, enabled now.

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #24 on: December 10, 2017, 08:54:46 am »
Ok I try to reproduce error on both php5.6 and php7.1 and didn't get any error. I tested it on default installation(no other plugin only stock, with one example ad) with bender theme, can't comment on osclasswizards as I don't have it.
More info will be needed to resolve it. I have enabled issues on github, so we can discuss it their.
Regards

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #25 on: December 10, 2017, 09:25:22 am »
OsclassWizards is free, you can get it and test it.

As for the rest, i also have no plugins installed but i run 7.0 and not 7.1.


Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #26 on: December 10, 2017, 05:11:30 pm »
Should i start with a clean db ?

Because i didn't. I used the 3.7.4 already used in my tests.

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #27 on: December 10, 2017, 06:31:11 pm »
Give it a try.

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #28 on: December 10, 2017, 06:36:55 pm »
Give it a try.

I will but thas means people will not be able to update. Only new people will be able to use the refactored script.

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #29 on: December 10, 2017, 07:00:38 pm »
But it will confirm the issue. I will fix it for sure. Currently working on my client work.