Advertisement:

Author Topic: Experimental Osclass fork  (Read 3216 times)

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #30 on: December 10, 2017, 09:26:36 pm »
But it will confirm the issue. I will fix it for sure. Currently working on my client work.

Installed from scratch with no problems (created db etc etc).

THIS:

[09-Dec-2017 20:30:15 Europe/Madrid] PHP Notice:  Array to string conversion in /home/oc-includes/osclass/helpers/hSanitize.php on line 183

remains as before.

As for the OsclassWizards error i will check later. Your installation is missing Bender theme folder files (only a folder is included), so i'm installing it.


Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #31 on: December 10, 2017, 09:53:54 pm »
An issue: Switching from bender to OsclassWizards theme, i see this:

[09-Dec-2017 20:36:37 Europe/Madrid] PHP Notice:  Plugin osclasswizards is missing the index.php file /home/oc-content/plugins/osclasswizards/index.php in /home/oc-includes/osclass/classes/Plugins.php on line 124

The Osclasswizards is untouched and i REinstalled it from Market. And Index.php is not missing, it is there.

Well, on the virgin installation that error doesn't show. I have no idea why, but it doesn't.


navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #32 on: December 10, 2017, 10:17:22 pm »
Hey thanks for your hard work. I will check it as soon as I get sometime.
Regards

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #33 on: December 10, 2017, 10:20:22 pm »
Hey thanks for your hard work. I will check it as soon as I get sometime.
Regards

Actually it is YOUR hard work not mine.

 ::)

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #34 on: December 13, 2017, 02:48:34 pm »
Thanks, really appreciated.

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #35 on: December 13, 2017, 02:54:50 pm »
Thanks, really appreciated.

But he is just a damn spammer, he just copied in full my first reply to you:


https://forums.osclass.org/development/experimental-osclass-fork/msg158422/#msg158422

« Last Edit: December 13, 2017, 02:57:14 pm by Aficionado »

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #36 on: December 13, 2017, 02:59:24 pm »
And he INSERTED a LINK into your quote !!!! to his site(s) !!!

Reported.
« Last Edit: December 13, 2017, 03:01:30 pm by Aficionado »

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #37 on: December 13, 2017, 03:04:22 pm »
And he INSERTED a LINK into your quote !!!! to his site(s) !!!

Reported.
Ohh I didn't checked it.

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #38 on: December 13, 2017, 03:06:17 pm »
And he INSERTED a LINK into your quote !!!! to his site(s) !!!

Reported.
Ohh I didn't checked it.

No problem, i emailed info @ Osclass about it, since it seems that the REPORT function of the forums doesn't reach a valid mailbox.

teseo

  • Hero Member
  • *****
  • Posts: 6169
Re: Experimental Osclass fork
« Reply #39 on: December 13, 2017, 06:20:53 pm »
Hi,

Outstanding job, Navjot Tomer  :)

I'm testing it and reviewing the code, so far so good.

Many thanks for this initiative, regards

xop32

  • Jr. Member
  • **
  • Posts: 77
  • trend following
Re: Experimental Osclass fork
« Reply #40 on: December 17, 2017, 05:23:03 am »
it does sound like a good idea

1) there are a lot of libarys used in osclass that are outdated, but its going to be a big task to take on to update them

2) what about trying to get composer involved in handling updates of packages included in osclass

3) someone please fix the uk regions file as well ( united kingdom has been missing a whole country (wales) for years now )

4) creating a stock theme for osclass that is simply based around bootstrap would be a very good improvement in itself over the stock theme

 

Aficionado

  • Guest
Re: Experimental Osclass fork
« Reply #41 on: December 17, 2017, 03:13:37 pm »

3) someone please fix the uk regions file as well ( united kingdom has been missing a whole country (wales) for years now )

4) creating a stock theme for osclass that is simply based around bootstrap would be a very good improvement in itself over the stock theme

Those two have nothing to do with the topic we discuss.

For your (3) see:

https://forums.osclass.org/general-help/osclass-geo-databases/

and continue in there if you wish.

 8)

dev101

  • Osclass Hero
  • Hero Member
  • *
  • Posts: 2132
  • osclass.work
Re: Experimental Osclass fork
« Reply #42 on: December 17, 2017, 11:00:09 pm »
Hi navjottomer,
I just saw this topic here and briefly looked at the work you've done. Awesome!

However, I have a friendly tip: split things. Don't do everything in one branch, because most probably it wan't all be accepted into dev, and later into master. Don't let few things stop the entire PR.

So, smaller things, like code realignment, refactoring, phpdoc, typos and similar stuff should go to => Osclass dev branch, directly. Also, it makes tracking issues/PRs more easily for everyone.

This way you'll save time and focus on important things in your version.

This is just my opinion, and also, to make it easier for the Osclass Team to review and accept your changes.

And, OT already announced few months earlier they will start removing things for the 4.0 version, but it is not so clear when that will happen, so...

Regards,
dev101

navjottomer

  • Tutor
  • Sr. Member
  • *
  • Posts: 373
  • I am here
Re: Experimental Osclass fork
« Reply #43 on: December 24, 2017, 12:05:59 pm »
Hey, everyone was busy with my client work in last two week and forgot to track record of this thread.
First thanks everyone for encouragement and suggestions.
Hi navjottomer,
I just saw this topic here and briefly looked at the work you've done. Awesome!
...
And, OT already announced few months earlier they will start removing things for the 4.0 version, but it is not so clear when that will happen, so...

Regards,
dev101
I was thinking about that too, will split workflow to different branches in future.

it does sound like a good idea

1) there are a lot of libarys used in osclass that are outdated, but its going to be a big task to take on to update them

2) what about trying to get composer involved in handling updates of packages included in osclass
 ...
I have plan to use composer for library handling.  For regions I think we need to create another repo for that and that is out of my scope as being a single person doing all the work. I also have a plan to include a new theme for osclass but that too in future.

Here are the goals:
Cleaning and Refactoring Code.
Updating Library.
Adding small new features.
Removing dependencies of plugins for few standard features.

Although goals are simple but need lots of time and I need every help to mitigate this issue.

Regards
« Last Edit: December 24, 2017, 12:07:39 pm by navjottomer »

dev101

  • Osclass Hero
  • Hero Member
  • *
  • Posts: 2132
  • osclass.work
Re: Experimental Osclass fork
« Reply #44 on: December 24, 2017, 07:20:48 pm »
Personally, I don't vote for Composer with Osclass, reason being quite simple: some libraries are customized to provide better/broader compatibility. It's not just possible to use blind latest version updates.

There are 2 attempts to integrate it, and both are kind of abandoned / incomplete.

Conejo also mentioned that Osclass will continue to provide all necessary libs as a standalone complete package, which is user friendly for most users.

Also, take a look at WordPress, same thing.