Advertisement:

Author Topic: Madhouse Messenger Duplicate Messages Issue  (Read 257 times)

TangoX

  • Jr. Member
  • **
  • Posts: 64
Madhouse Messenger Duplicate Messages Issue
« on: August 07, 2018, 11:19:11 pm »
Guys, I have an issue with the Madhouse Messenger plugin (unsupported anymore).
Every new message received by the user, gets duplicated in the inbox and also in the backend (see screens).
Screen1
Screen2

From what I understand, the issue appeared in Osclass v3.7.3 because of this commit.
At the time, the developer fixed the issue by releasing an update, which worked fine.

The problem is that with the release of Osclass v3.7.4 the bug returned.
My question is, what was the change in v3.7.4 (also in v3.8.0) that made the bug reappear and what could I do to fix it?

Thanks!

---------------------------------------------------------------------------

Edit: Gosh, I've never seen a plugin so complex as this one.
It's like a framework on top of another framework (1757 files)...

I've compared the 2 versions of the plugin (the one with the bug, and the one with the fix) and I can't see any difference in the code, and that's because the fix is external, as the plugin has a bunch of external dependencies.
It has a composer.lock file with:
Code: [Select]
"name": "madhouse/utils",
            "version": "1.25.3-rc.1",
            "source": {
                "type": "git",
                "url": "git@bitbucket.org:muchmuch/madhouse_utils.git",
                "reference": "ef65674d4fab42955b00a007690b597cff603e0d"
            }

So I guess I'm out of luck on this one.

Also, I've noticed that by reverting this commit, the bug goes away.
Could this cause any issues with other parts of the Osclass core?
« Last Edit: August 08, 2018, 12:56:40 am by TangoX »

dev101

  • Osclass Hero
  • Hero Member
  • *
  • Posts: 1979
  • osclass.work
Re: Madhouse Messenger Duplicate Messages Issue
« Reply #1 on: August 09, 2018, 02:46:26 am »
Hi, if I'm not mistaken, Hussard/adrienrn is (or was) a member of MadHouse. So, it doesn't make much sense that his/their commit, that was related to Messenger plugin, doesn't work (unless you use an older version).

About safety of using the old code version, you should be in general safe, unless some plugin or theme starts looping strings or objects, as Hussard mentioned in that PR.

P.S. I cannot directly help you, as I don't have that plugin.

Regards
dev101

TangoX

  • Jr. Member
  • **
  • Posts: 64
Re: Madhouse Messenger Duplicate Messages Issue
« Reply #2 on: August 10, 2018, 09:57:04 pm »
Thanks for the reply Darko.

Indeed, Adrien was a member of Madhouse, but the pull request was made in 2015 and it was finally merged in 2017 on Osclass v3.7.3.
The merge actually created the issue for the Messenger plugin, but got fixed by Madhouse shortly after.

The problem is that the issue reappeared in v3.7.4, but it's impossible to fix, as it's something related to the Madhouse Utils system, which is external and hosted on private Bitbucket.

So in order to fix it, a dev has to either rewrite the entire plugin, or get access to the Madhouse Bitbucket repository.

But it's good to know, that reverting the commit won't cause Osclass core issues.
I guess I'll have to freeze my plugins to the actual versions, that don't loop strings and stuff. :D
« Last Edit: August 10, 2018, 10:01:19 pm by TangoX »