Osclass forums

Development => Plugins => Topic started by: SmaRTeY on August 15, 2015, 07:26:35 pm

Title: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on August 15, 2015, 07:26:35 pm
Hi All,

I decided to work on an alternative for the current "Cookie Cutter" plugin since I really dislike the page reload which I couldn't get rid of.
After doing some research on the internet I found this plugin on Github and decided to 'fork' their plugin to Osclass  8)
(https://silktide.com/tools/cookie-consent/ (https://silktide.com/tools/cookie-consent/))

Now it took me about two days to analyse, create, test, bugfix, analyse more, test more and I am proud to say, "DONE!"  ;D
The plugin makes it easy for Osclass Admins to comply with European Cookie Law and it has ALL features incorporated.

I am offering the plugin on Osclass Market for free, so in case you are interested just ask _CONEJO to speed up the review haha  :P
I am using it myself, I made the whole plugin INDEPENDENT from 3rd party sources, so both CSS as Javascript are stored on your own server. The Javascript is independent itself as well so no JQuery dependencies or any other.

NB. If you use the 'Wizard' on their website the code you get is a one time script AND it 'links' for both script & css to an Amzon website.

This plugin offers FULL control ie. in Admin:
- you can choose color scheme
- set cookie window position
- set your own Cookie Policy URL

The plugin is 100% MULTI-LANGUAGE using PO/MO files.

FEATURES:
- Light color - Top
- Light color - Bottom
- Dark color -Top
- Dark color - Bottom
- Light color - Floating
- Dark color - Floating

Attached a screenshot of "dark-bottom" setup and multi-language ofcourse.

Demo site: http://www.spulleboel.nl (http://www.spulleboel.nl)

Hope you will be able to start downloading this new free little Osclass 'gem' *soon*

http://market.osclass.org/plugins/miscellaneous/cookie-consent_387
Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: dev101 on August 15, 2015, 08:29:23 pm
Thanks SmaRTeY! Looking forward to it! :)

dev101
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on August 15, 2015, 10:06:54 pm
Thanks Eric !!!

Looking forward to it (as much as i HATE that EU policy crap).

Is it ok by the law to have an auto-close option after some seconds ?

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: gnoe on August 15, 2015, 10:57:29 pm
Great job SmaRTeY, thanks.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on August 16, 2015, 12:15:04 am
Thanks Eric !!!
You're all welcome :)

Quote
Looking forward to it (as much as i HATE that EU policy crap).
Haha you, me and many others Aficionado ;D

Quote
Is it ok by the law to have an auto-close option after some seconds ?
I don't think that would comply with their rules, you as website visitor need to 'agree' and be able to agree (or leave again ofcourse).
In case of auto disappear that would no longer be possible and someone could probably sue you with succes(!)..... stupid but legal.
Site owners do have to be carefull, Google Adsense for example is emailing their users to comply with the cookie warning option on your website or else they are blocking your site because legislation says Google should do so or else they are held responsible as well.

So stupid yes, take it serious I think yes as well if you're a serious website owner doing (public) business on the internet.

My philosophy here is; the better your site ranks with regard to visitor/user privacy the better it is 8)


Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: pixellegolas on August 17, 2015, 06:20:29 pm
Great stuff. But I am also curious of what theme you are using in the demo.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on August 17, 2015, 06:22:33 pm
Great stuff. But I am also curious of what theme you are using in the demo.

Boxer Theme.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on August 17, 2015, 11:31:04 pm
Yes, it 'was' originally Boxer before I started making changes (and I am still not 100% done) 8)

Great stuff. But I am also curious of what theme you are using in the demo.

Boxer Theme.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on August 18, 2015, 12:08:28 am
Small update, in market it is now version 1.2. thanks to some help from teseo & dev101 8)
Changes in short:

- added some small security prevention
- improved admin visuals
- improved javascript, now also supports Osclass installs 'outside' root folder (ie. in subfolder of root) Yoehoeoeoe!! ;D

Now I really consider it done :)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on August 18, 2015, 02:45:59 pm
I'm sorry but i can't find it on Osclass Market.

 :'(
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: DrizzleThemes on August 18, 2015, 04:05:08 pm
@Smartey

Really cool addon..  8)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on August 19, 2015, 02:42:04 am
I'm sorry but i can't find it on Osclass Market.

 :'(

This takes some serious time....can't help speeding up review :|
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: tabuausada on August 20, 2015, 12:08:39 am
Great job SmaRTeY!!! Can't wait to download from market thanks!
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on September 10, 2015, 11:02:40 pm
Well, how do we get this plugin before getting old?

It is not available in the market after a month or so....

 ;D
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 11, 2015, 02:31:45 am
Yes, three weeks now :(
But they have more plugins/themes to check and maybe other work though it does take long if you're waiting...
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: frosticek on September 11, 2015, 11:27:39 am
@SmaRTeY
I have 2 plugins there that hangs about 2 months. Once for 2-4 weeks I get message from osclass there is some problem/error/undefined index, fix it in 5 minutes and wait another 2-4 weeks for next message.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 11, 2015, 07:59:40 pm
Well, we are told it's busy and it can take extra time BUT smartly enough there's no mentioning of a max. wait time if I am correct...
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: frosticek on September 11, 2015, 09:17:39 pm
@SmaRTeY
Correct, no max validation time is set  :-X
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 12, 2015, 02:16:30 pm
Okay, I have good news, the plugin has been reviewed and will be open for download any day now.
I had to revise my version nr. to 3 digits instead of 2 (my wrong) and since it is still within 4 weeks after posting the new plugin I think it is acceptable wait time. My previous plugins were also reviewed and approved within 4 weeks which is fine by me.  8)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 13, 2015, 03:09:12 am
For those interested, the plugin is available for download in Market (http://market.osclass.org/plugins/miscellaneous/cookie-consent_387)! ;)

EDIT: Not yet mentioned here but it also is 'responsive' ie. this also works pretty good with responsive websites.


Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on September 21, 2015, 02:23:03 pm
I have a problem with the plugin. I spend a lot of time each day in my osclass websites.

And many times i'm seeing the cookie bottom line with no reason. Not sure when and why. Usually when i open a second tab to check a listing.

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 21, 2015, 10:12:27 pm
HI Aficionado,

open a second tab in your browser?

EDIT:
Please tell me what browser you use, what Osclass version and the exact scenario.
I just tried what you mention, open a new tab showing a list item but cookie-bar does not re-appear.

I have a problem with the plugin. I spend a lot of time each day in my osclass websites.

And many times i'm seeing the cookie bottom line with no reason. Not sure when and why. Usually when i open a second tab to check a listing.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on September 21, 2015, 10:13:15 pm
HI Aficionado,

open a second tab in your browser?


yes !
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 21, 2015, 10:17:24 pm
Okay, please tell me what browser, Osclass version and more specific the scenario because I can't reproduce at the moment.
Also if permalinks are on/off....you never know
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on September 21, 2015, 10:49:21 pm
Okay, please tell me what browser, Osclass version and more specific the scenario because I can't reproduce at the moment.
Also if permalinks are on/off....you never know

Well i can't reproduce is either, it just happens randomly.  Osclass latest and Firefox latest. Windows 10 64bit
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 21, 2015, 11:04:36 pm
Mmmm well I use my Osclass site also on a daily basis and for several hours in a row using Win10-64 on Edge but never experienced your issue (yet). Could it be Firefox cache related?

I am very curious if others experience the same and what browser they are using when this happens.

Very hard for me to track it down since the cookie-consent code is Open Source, I only created an Osclass wrapper and included the JS and CSS so it's independent. I'll have a look at their page and see if there are any known issues like yours.

Thanks,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 21, 2015, 11:09:44 pm
Here's a list of open issues on Github regarding the cookie consent 2.0 code that I used:
https://github.com/silktide/cookieconsent2/issues?q=is%3Aopen+is%3Aissue (https://github.com/silktide/cookieconsent2/issues?q=is%3Aopen+is%3Aissue)

There even is a smarty issue(!) haha but seriously, I have no issues whatsoever but maybe that is because of my JQuery 1.11.3 version (http://blog.jquery.com/2015/04/28/jquery-1-11-3-and-2-1-4-released-ios-fail-safe-edition/).

Also, some of the issues are not issues just wishes or very specific issues, I do not see anything that resembles your issue but maybe you recognize one?
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 21, 2015, 11:31:07 pm
Aficionado and everybody else,

since the cookie consent code is still being updated/improved I will post an update soon in this thread on "How to update the Cookie Consent JS to the latest version" using the Original Cookie Consent code from Github.

That's about all I can and will do with regard to this plugin related to 'Cookie Consent' and any issues you might experience unless it is related to the wrapper code I created but that is highly unlikely ofcourse ;D
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on September 21, 2015, 11:45:33 pm
I was using previously the Osclass team cookie plugin and never had that problem, so this is new.

I will try to find more details about the problem and let you know.

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 22, 2015, 09:31:38 am
Yes please do so, I never had issue with both plugins but depending on situation there can always be -something- that either is related to something in Osclass setup (theme/other plugins/server/browser/etc.) or the javascript/plugin wrapper script.

Since your issue is randomly it would help if anybody reading this thread and experiencing similar issue let us know so I can hopefully figure out what is going on. My first thought is maybe JS working in your site due to order/other JQuery version/Plugin or specific browser related where script re-fires for some reason.


Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: romantica on September 22, 2015, 02:50:15 pm
hi, good work this plugin on my site but does not appear! What for?
thank you for help
I'm on 3.3.2 osclass
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on September 22, 2015, 04:21:52 pm
Yes please do so, I never had issue with both plugins but depending on situation there can always be -something- that either is related to something in Osclass setup (theme/other plugins/server/browser/etc.) or the javascript/plugin wrapper script.

Since your issue is randomly it would help if anybody reading this thread and experiencing similar issue let us know so I can hopefully figure out what is going on. My first thought is maybe JS working in your site due to order/other JQuery version/Plugin or specific browser related where script re-fires for some reason.


Regards,
Eric

Maybe it has to do with some caching i use. I will have to test things and keep you posted.

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 22, 2015, 06:39:37 pm
Hi romantica,

I can see it work on your ABC & Riviera site, see attached images.
However, I think you are missing the French language translation or something similar since the text is not being translated which should since it is using Osclass default PO/MO code. Please check your PO/MO file for correct strings as in included en_US or nl_NL file.

hi, good work this plugin on my site but does not appear! What for?
thank you for help
I'm on 3.3.2 osclass

Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 22, 2015, 06:43:17 pm
Thanks Aficionado

Yes please do so, I never had issue with both plugins but depending on situation there can always be -something- that either is related to something in Osclass setup (theme/other plugins/server/browser/etc.) or the javascript/plugin wrapper script.

Since your issue is randomly it would help if anybody reading this thread and experiencing similar issue let us know so I can hopefully figure out what is going on. My first thought is maybe JS working in your site due to order/other JQuery version/Plugin or specific browser related where script re-fires for some reason.


Regards,
Eric

Maybe it has to do with some caching i use. I will have to test things and keep you posted.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: romantica on September 24, 2015, 07:18:27 pm
thank you but must see which file for translation?
I can not find.
thank you for help
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 24, 2015, 07:51:31 pm
I think if you create a fr_FR PO/MO file the messages will be there as they are in dutch and english.

For messages to appear you either need to set english as default language or make sure you have *all* po/mo files available for the languages you offer your users in Osclass.
In your case my bet is that the French folder in languages folder and french po/mo files in fr_FR folder is missing so you need to create it.
Read about po/mo files here: https://blog.osclass.org/2011/09/06/translating-osclass-plugins-themes/ (https://blog.osclass.org/2011/09/06/translating-osclass-plugins-themes/)

A quick fix to see if it works could be:
1) create the folder 'fr_FR' in the plugin's 'languages' folder on your server
2) copy the english .po and .mo file and paste them in this fr_FR folder

If it works you will see english text in the cookie appear instead of the current text placeholders.

Next you can download and open the messages.po file from the fr_FR folder using po-edit and change the file properties from English to French.
Then translate the English translations in your PO file into your own French translations.
Then save the PO file and let po-edit create the new MO file when saving.
Then upload and overwrite both the PO/MO files in your fr_FR folder and you should get the French translation next time cookie is displayed.

thank you but must see which file for translation?
I can not find.
thank you for help
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: buninsan on October 07, 2015, 08:20:08 pm
google do not like it
https://developers.google.com/speed/pagespeed/
Use the browser cache for the following resources:
https://s3-eu-west-1.amazonaws.com/...ent.silktide.com/cookie-consent-logo.png (Unknown validity)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on October 09, 2015, 02:26:44 am
Thanks buninsan,

I see there is still one dependent item, cookie-consent-logo.png, I will fix that by making it a 'local' image.

With regard to Google's Pagespeed, that is not something I will look into as there's not much to do about it but I am open for suggestions.

google do not like it
https://developers.google.com/speed/pagespeed/
Use the browser cache for the following resources:
https://s3-eu-west-1.amazonaws.com/...ent.silktide.com/cookie-consent-logo.png (Unknown validity)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 07, 2015, 12:24:01 am
Hi there,

New (patched) version is on it's way, version 1.2.1 in Market, now in review so please be patient.

Changes:
- Added changelog.txt :)
- Replaced 1 remote image file with a local file
- Added a Quick Language Reference to make it easier for Admins to add language support for their website active languages
- Updated version to 1.2.1

Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Xunil83 on November 07, 2015, 06:49:52 pm
Hi, I have a problem with this plugin. In administer plugins page can not edit this plugin because I can not see the word "configure ".
(http://www.trovabiker.it/screenshot.png)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 07, 2015, 07:07:17 pm
Hi,

The 'config' option not appearing is most likely a server or database issue. I had a similar issue where in the plugin list not one config was showing. It turned out to be related to my server setup, more specific the way I had php-fpm configured (http://forums.osclass.org/general-help/i've-lost-'configure'-in-my-plugins-screen-(oc-admin)/) on Centos/Apache.

Is 'config' only missing for the cookie consent plugin or for other plugins as well?

To keep things more simple, you can also try to remove the cookie consent plugin, check if folder and files have been deleted and try a new upload/install. The plugin comes with a 'config' option like other plugins, the code for this is 'default'. If after reinstall the 'config'  option is still not showing in your plugin overview most likely something else is giving you issues.


Regards,
Eric
Hi, I have a problem with this plugin. In administer plugins page can not edit this plugin because I can not see the word "configure ".
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Xunil83 on November 13, 2015, 03:19:42 am
The config option for the other plugin is visible. I tried uninstalling and reinstalling the cookie consent plugin but it is the same.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 13, 2015, 02:44:40 pm
Okay, please tell us what Osclass version you are using, what theme (+version)?
Also, are you on VPS/Dedi or Shared Hosting?

Have you tried turning on DEBUG to see if there are any errors related to Cookie Consent (or any other) ?
If not please do so and tell us if there are errors.

Another trick you can do yourself is turning of/uninstalling all plugins and then start with installing cookie consent plugin to see if config is showing. If it is not we need to look at other possibilities if it is you can turn one plugin at time back on and keep checking if config is still there after each newly added plugin.

The config option for the other plugin is visible. I tried uninstalling and reinstalling the cookie consent plugin but it is the same.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Xunil83 on November 14, 2015, 02:38:08 am
Version 3.5.9 of Osclass, osclasswizard theme, shared hosting. I can not uninstall all plugins and do a review, it would be easier for me to keep my problem.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 14, 2015, 12:17:24 pm
Okay, well I tested the plugin with the OsclassWizardTheme and there is no problem so your issue must be related to something else in your (Admin) setup. No problem if you do not want to analyze but be aware, having such an issue might give you more trouble than you think in current or future use of Osclass.

I see you are using an 'old' version, in Market there's a new version available that might work better for you though there are no changes related to Admin Plugin addition.

One last question, what php version do you have installed?


Regards,
Eric

Version 3.5.9 of Osclass, osclasswizard theme, shared hosting. I can not uninstall all plugins and do a review, it would be easier for me to keep my problem.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on November 17, 2015, 03:00:12 pm
Eric,

I'm seeing a LOT of this:

Code: [Select]
http://website.com//oc-content/plugins/cookie_consent/styles/dark-bottom.css
Why i have a double "//" ? Is that normal ?

Thanks
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: dev101 on November 17, 2015, 03:32:11 pm
Yes, there seems to be a small bug in the path, open js/cookie_consent.min.js and replace /oc-content with oc-content (2 places).

Regards
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on November 17, 2015, 04:11:23 pm
Thanks dev101

 8)

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 17, 2015, 10:54:14 pm
Hi Aficionado,

where exactly do you see these lines?
I am inspecting my logfiles pretty regulary and I have not seen that 'error' yet.

The fix mentioned by dev101 will work just fine but I will fix it in plugin asap!

Thanks for sharing!

Eric,

I'm seeing a LOT of this:

Code: [Select]
http://website.com//oc-content/plugins/cookie_consent/styles/dark-bottom.css
Why i have a double "//" ? Is that normal ?

Thanks
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on November 17, 2015, 10:58:37 pm
I see them in my Cpanel Recent Visits and also verified them in my webserver log files.

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on November 17, 2015, 11:08:03 pm
Here it come one of the two "//"

The Second is

Code: [Select]
http://website.com//oc-content/plugins/cookie_consent/styles/dark-bottom.css
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 18, 2015, 12:24:57 am
Thanks again, I found it and it is indeed a nasty buggy!
I will update, test and upload new version asap.


Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on November 18, 2015, 12:56:46 am
Nasty ? I don't think so because for some reason the double // works as single. I mean the url is served right.

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 18, 2015, 01:02:31 am
Yeah nasty as in 'sneaky'....no issues with the working of the plugin but it is incorrect path and in my error logs I don't see issues only in browser doing a manual check. :) Anyway, glad you noticed it so I can fix it.

Nasty ? I don't think so because for some reason the double // works as single. I mean the url is served right.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 18, 2015, 01:24:22 am
Okay, new version is uploaded to Market (1.2.2) so will be a little while before it is ready for download but it's a small fix so review can be pretty fast.
Fix is like dev101 mentioned, simple path correction in javascript file. 8)

Thank you both,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on November 18, 2015, 03:26:15 pm
No, WE thank you Eric for your contribution for this (small ?) community.

 ;D
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on November 18, 2015, 05:40:46 pm
Well, this small community is helping each other which is exactly what I like in a community ;)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: gnoe on January 08, 2016, 02:45:54 pm
I have similar issue with Xunil83.
Configure option is missing and cannot access any plugin's admin options.
Tried re-installation with no success.

PHP-FPM here too.
Can you add a Configure link on left osclass admin sidebar, like some other plugins have?

Regards.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on January 08, 2016, 03:19:34 pm
For those who have that problem, don't try to overcome it via strange methods. Find the REAL cause of your problem (apparently some hosting or server setup) and solve it !!

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: dev101 on January 08, 2016, 07:30:28 pm
I have made 2 mods in the latest version to make it compatible with some of my internal plugins and to fix one bug:

(1) increase z-index from 9001 to 1000000 (...000...)
(2) escape ccp var string (now it returns : error)

Configure link works just fine in my admin dash (also PHP-FPM) and I cannot see anything wrong in the plugin code in that regard.

Regards
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: gnoe on January 08, 2016, 11:54:57 pm
Nginx & php-fpm here.
I have it disabled for now, till I figured out what's wrong and can't see Configure option.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on January 09, 2016, 08:41:54 pm
Would be interesting to know how it works with Nginx if your server is not running php-fpm.
Reason for mentioning is that I had similar issue which was related to the php-fpm config in my apache VirtualServer's.

Nginx & php-fpm here.
I have it disabled for now, till I figured out what's wrong and can't see Configure option.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on January 09, 2016, 09:14:30 pm
Hi dev101,

I do not recognize the error mentioned in (2), all mentioned issues should be fixed, do you use latest version from Market?

One possible issue you might run into IF your browser is not HTML5 compatible related to the ccp var is the missing text inside the script tag: type="text/javascript" (http://www.w3schools.com/tags/tag_script.asp)

For HTML5 that property is no longer needed but if your browser is not compatible with HTML5 it might raise an error?

I have made 2 mods in the latest version to make it compatible with some of my internal plugins and to fix one bug:

(1) increase z-index from 9001 to 1000000 (...000...)
(2) escape ccp var string (now it returns : error)

Configure link works just fine in my admin dash (also PHP-FPM) and I cannot see anything wrong in the plugin code in that regard.

Regards
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: dev101 on January 10, 2016, 02:21:04 am
edit:

Sorry, I see that you have changed that line, it is possible that I used older version somehow where that string was not escaped.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on January 11, 2016, 02:44:19 am
:)
That's okay.

@All, let me know if there's an issue with the plugin, I'll do my best to fix it again.

Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: gnoe on February 15, 2016, 10:57:53 am
Had issues on a nginx/php-fpm box and couldn't see/use the Configure page.

The problem solved by adding osc_plugin_path() in 'cookie_consent_config' line (index.php).

Code: [Select]
//(Un)install hooks
osc_register_plugin(osc_plugin_path(__FILE__), 'cookie_consent_install');
osc_add_hook(osc_plugin_path(__FILE__) . '_uninstall', 'cookie_consent_uninstall');

//osc_add_hook(__FILE__ . '_configure', 'cookie_consent_config');
osc_add_hook(osc_plugin_path(__FILE__) . '_configure', 'cookie_consent_config');

//plugin hooks
osc_add_hook('before_html', 'load_ccs');
osc_add_hook('header','cookie_consent');

Regards.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on February 16, 2016, 12:59:37 am
Hi gnoe,

that is a very interesting find, I am willing to put it into a new plugin version but I would like to know a bit more about this.
I had an issue myself with a missing 'config' link using VPS & Apache setup where the php-fpm 'config' on my server was the cause. Once I changed the php-fpm 'config' (different line of config, same result) the config link was showing again, very strange but it happened.

SO, I am wondering if there's a 'bug' by ommitting the 'osc_plugin_path' in the code of this hook or not (since I do not experience the issue with this plugin). Also I have other plugins in use that have the same 'config' code and all are showing the config link as expected.

@_CONEJO, if you are reading along (or anybody else with a more expert knowledge), any thoughts on this matter would be much obliged....

Thanks gnoe!

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: gnoe on February 16, 2016, 12:29:19 pm
Hi SmaRTeY,
on some tests I did weeks ago, the plugin was working just fine.
These tests were performed on Apache. Both localhost and live site.
I don't remember the php mode(fastcgi,php-fmp).

I had issues with Configure page not showing, only on a Nginx/PHP-FPM setup with Cookie Consent plugin and lately with teseo's Pre-resize images new plugin.
Other plugins were OK.

After communicating with teseo, he provide me some new index.php files to try and the issue was solved.
Then, after some file comparing, I tried adding osc_plugin_path() to Cookie Consent Plugin's index.php to see if it works there too.
And it worked just fine.

I haven't touched PHP-FPM or Nginx config files.

Regards.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on February 17, 2016, 12:06:36 am
Hi,

someone else was asking me support for a premium plugin having same issue and after he made the change you mentioned it worked for him as well. Same server setup NGINX with php-fpm so my conclusion here is that best practice now for plugins showing the config link in plugin overview page will best do so by adding the 'osc_plugin_path()' so NGINX setups will work OK. I tested with my VPS (Apache) and so far no behaviour changes by adding the 'osc_plugin_path()' so I will update my plugin(s) in the market with this fix!

Thanks again Gnoe/teseo

Hi SmaRTeY,
on some tests I did weeks ago, the plugin was working just fine.
These test were performed on Apache. Both localhost and live site.
I don't remember the php mode(fastcgi,php-fmp).

I had issues with Configure page not showing, only on a Nginx/PHP-FPM setup with Cookie Consent plugin and lately with teseo's Pre-resize images new plugin.
Other plugins were OK.

After communicating with teseo, he provide me some new index.php files to try and the issue was solved.
Then, after some file comparing, I tried adding osc_plugin_path() to Cookie Consent Plugin's index.php to see if it works there too.
And it worked just fine.

I haven't touched PHP-FPM or Nginx config files.

Regards.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: teseo on February 17, 2016, 12:34:38 am
Hi SmaRTeY, :)

The thing is that I'm using Nginx with php-fpm and that never happened to me. ??? But whatever works... :D

Regards

Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on February 17, 2016, 01:07:29 am
AAAARRRRRGGGGGGG ;)
I am willing to think that a certain NGINX setup is having issues with config link missing IF 'osc_plugin_path()' is missing in hook. I never tested my Apache missing config link issue with this but who knows. Also it looks as if adding 'osc_plugin_path()' makes more sense also looking at uninstall 'link' which is shown in same overview.
 
On the other hand, even though another NGINX setup or use of Apache does work, it does not seem to harm the config link IF the 'osc_plugin_path()' is added. Meaning in the end that adding the 'osc_plugin_path()' in config link hook is covering more 'ground' of succesfull config plugin links :)


Hi SmaRTeY, :)

The thing is that I'm using Nginx with php-fpm and that never happened to me. ??? But whatever works... :D

Regards
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: gnoe on February 17, 2016, 10:50:58 am
To osc_plugin_path() or not to osc_plugin_path() ?
That is the question.  :D

At the end, what is the best programming practice?


Hi Teseo,
can you share you nginx directives for your osclass installation?
Since it's a path issue, maybe there is something different or missing there.
Mine is below.

Code: [Select]
location / {
   try_files $uri $uri/ /index.php?$args;
}

Regards.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: teseo on February 17, 2016, 01:37:40 pm
Code: [Select]
location / {
   try_files $uri $uri/ /index.php?$args;
}

Same here. Anyway, given the fact that there is a universal alternative that works, I won't spend more time looking for explanations...  ::)

Regards
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on March 29, 2016, 12:11:50 am
A new version is uploaded in the Market containing the fix Gnoe mentioned, it is under review and will soon be available for download.

Best regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: deyan4 on September 21, 2016, 11:42:05 am
Hello,

how can I change the message and the bottom text?

Thanks.
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on September 27, 2016, 09:56:39 pm
Hi there,

you can change language strings using the PO/MO Editor, download PO file you want to change, open PO file using POedit, make changes to text, save changes and upload both PO and MO file back to server in language folder.

Read the README.txt howto add more language files (PO/MO)


Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on August 22, 2017, 05:24:55 pm
Eric,

If you have Firefox, can you check if the cookie notice comes back in every page i visit ?

Thanks

(it appears that Osclass doesn't work well anymore with Firefox and Edge and i guess the problem with your plugin is related)
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on August 23, 2017, 11:15:53 pm
Hi Aficionado,

I will have a look, I am Always using Edge thinking if it works there okay it will probably work in all browsers ok since Edge is mostly the one complaining about things ;) Anyway, with Edge it all works OK for me using my own website, just a one time cookie notice.
I'll have a look using FF, will be latest version (54.0.1), and get back here to share experience.

= EDIT =
Okay, no problems using FF and Cookie Consent on my website, you want me to check your website using FF ?


Regards,
Eric
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on October 29, 2017, 04:08:15 pm
Firefox 56.02, can somebody check if it works for you ? For me it asks for cookies again and again.

thanks
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: mrtsoftware on October 30, 2017, 08:34:50 pm
I have checked on FİREFOX browser and it runs ok. No problem
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on October 30, 2017, 08:56:33 pm
I have checked on FİREFOX browser and it runs ok. No problem

Thanks, i was suspecting that. Something is wrong with FF and my laptop. I will be removing/reinstalling ....
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on April 13, 2018, 09:56:18 pm
Hi Eric,

Any news or ideas about your plugin and the new GDPG ?

Thanks !!!
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on May 09, 2018, 06:54:57 pm
https://forums.osclass.org/general-help/gdpr-compliance-and-osclass/msg162196/#msg162196
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: SmaRTeY on May 15, 2018, 11:28:49 pm
Hi Aficionado,

it's been a while, a new job etc. but here I am again….
Actually I think the plugin is still OK as far as GDPG (or AVG in Dutch) goes?

Unless you are using cookies beyond the purpose of a correct functioning website (ie. marketing/analytics/etc.) the plugin is just fine. According to this website (http://"https://www.cookieinfo.net/cookies-en-avg-gevolgen-en-kansen-voor-je-website/") (in dutch) the AVH/GDPR restrictions do not apply to functional cookies. What you should do is use a clear statement that your website is using cookies ONLY for a correct functioning website. Unless you're not ofcourse :)

Osclass by default is not using cookies that track users or use personal data in cookies otherwise as far as I know. Any ID used in a cookie can only be abused when there's a security breach as far as I know. And to my knowledge Osclass is not containing such a security breach.

The plugin is based on open source Cookie Consent code, I will see if they have updated their code making it GDPR/AVG proof and if so I will try to create a new plugin but I have no intention of changing/updating the current plugin.

P.s. for the sake of AVG/GDPG, check your plugin creators for all plugins you use if any cookies are used and what user data they exactly may contain.


Regards,
Eric

Hi Eric,

Any news or ideas about your plugin and the new GDPG ?

Thanks !!!
Title: Re: *NEW* FREE COOKIE CONSENT Plugin
Post by: Aficionado on May 16, 2018, 12:58:49 am
Eric thanks !

Glad to see you are well !!

Take care !!!